If.....End If problem (I think) (VBA/Powerpoint/2000)

[tgmoon]

I'm having a bit of a problem with the following code.

Sub MySub()
On Error Resume Next

If ActiveWindow.Selection.ShapeRange().Name ="Bar" Then
Call MyBarCode(myVarients)

Else If
Call NoBarCode(myVarients)
End If
End Sub.

Basically, If an objected that has been prenamed "Bar" is selected, then it should do something to it, and if it's not selected it does something else. The problem is, when "Bar" isn't selected on the slide, the code is still running MyBarCode bit of the code.

[HansV]

If nothing is selected, the line

If ActiveWindow.Selection.ShapeRange().Name ="Bar" Then

causes an error. But since you have On Error Resume Next, the next line will be executed!

Your Else If is invalid since there is no condition after it. Try this version:

Sub MySub()
Dim sh As Shape
On Error Resume Next
Set sh = ActiveWindow.Selection.ShapeRange(1)
If Not sh Is Nothing Then
If sh.Name = "Bar" Then
Call MyBarCode(myVarients)
Exit Sub
End If
End If
Call NoBarCode(myVarients)
End Sub

[tgmoon]

Many thanks for the explaination Hans. I didn't realise I was using the Else If incorrectly.

many thanks